chore: update movement cli for testnet, a few other small cleanups #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygolay
requested review from
0xmovses,
l-monninger,
areshand,
sebtomba,
Rahat-ch and
shayansanjideh
l-monninger
reviewed
Jun 13, 2025
l-monninger
reviewed
Jun 13, 2025
andygolay
commented
Jun 13, 2025
l-monninger
previously approved these changes
Jun 16, 2025
musitdev
reviewed
Jun 19, 2025
crates/aptos/src/common/init.rs
Outdated
| profile_config.rest_url = Some("https://aptos.devnet.inola.movementlabs.xyz/v1".to_string()); | ||
| profile_config.faucet_url = Some("https://faucet.devnet.inola.movementlabs.xyz".to_string()); | ||
| profile_config.rest_url = | ||
| Some("https://aptos.devnet.inola.movementlabs.xyz/v1".to_string()); |
There was a problem hiding this comment.
We've a Devnet deployed. The entry point are:
https://full.devnet.movementinfra.xyz/v1
https://faucet.devnet.movementinfra.xyz
There was a problem hiding this comment.
Okay good to know, I'll update thanks.
crates/aptos/src/common/init.rs
Outdated
| Some("https://full.testnet.movementinfra.xyz/v1".to_string()); | ||
| profile_config.faucet_url = | ||
| Some("https://faucet.testnet.suzuka.movementlabs.xyz/".to_string()); | ||
| Some("https://faucet.testnet.movementinfra.xyz/v1".to_string()); |
There was a problem hiding this comment.
Faucet entry point doesn't have the /v1 the url is:
https://faucet.testnet.movementinfra.xyz
crates/aptos/src/common/init.rs
Outdated
| profile_config.rest_url = | ||
| Some("https://aptos.devnet.inola.movementlabs.xyz/v1".to_string()); | ||
| profile_config.faucet_url = | ||
| Some("https://faucet.devnet.inola.movementlabs.xyz".to_string()); |
| Some("https://faucet.devnet.inola.movementlabs.xyz".to_string()); | ||
| }, | ||
| Network::Local => { | ||
| profile_config.rest_url = Some("http://localhost:8080".to_string()); |
There was a problem hiding this comment.
The url doesn't have the /v1, so I'm not sure if it's needed for the other one.
I'm not sure the local url for movement node is not the 8080 port?
You can add a faucet url too.
There was a problem hiding this comment.
I thought :8080 worked for me but I'll double check.
|
Other than Philippe's comments, this looks good. |
|
@shayansanjideh @Rahat-ch should |
l-monninger
reviewed
Jun 24, 2025
| network | ||
| } else { | ||
| eprintln!("Choose network from [testnet, local, custom | defaults to testnet]"); | ||
| eprintln!("Choose network from [devnet, testnet, local, custom | defaults to testnet]"); |
l-monninger
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per devrel request, update Movement CLI network endpoints and ensure faucet works with testnet on
movement init.Changes:
movement init.movement init.config.yamlfiles to.gitingorebecause I noticed ongit add .myconfig.yamlfile was added.testnet. (Init with devnet also works.)Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
To test, run:
cargo build -p movementthen
./target/debug/movement initand play with the different options.
Key Areas to Review
Checklist
Outstanding Issues
localoption still fails due to [Bug]cargo run -p movement -- node run-local-testnetcrashes #174 but this should still be good to ship, for the improvements withtestnetanddevnet.